Thanks Álvaro for feedback. On Thu, 20 Feb 2025 at 02:39, Álvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > > Hello, > > I think the business with an evergrowing on_exit list needs a different > solution than a gigantic array of entries. Maybe it would make sense to > restructure that code so that there's a single on_exit item, but there > exists a list of per-database entries to clean up which are all done in > one call of the function. Then you don't need to change the hardcoded > MAX_ON_EXIT_NICELY array size there. >
In the latest patch, I added one new function to clean index(on_exit_nicely_index) with each database restore. > I think it would be better to have a preparatory 0001 patch that just > moves the code to the new files, without touching anything else, and > then the new feature is introduced as a separate 0002 commit. Fixed. > > You still have a bunch of XXX items here and there which look to me like > they need to be handled before this patch can be considered final, plus Fixed. > the TODOs in the commit message. Please pgindent. I am facing some errors in pgindent. I will run pgindent in the next version. Here, I am attaching updated patches for review and testing. -- Thanks and Regards Mahendra Singh Thalor EnterpriseDB: http://www.enterprisedb.com
v19_0001_move-common-code-of-pg_dumpall-and-pg_restore-to-new_file.patch
Description: Binary data
v19_0002_pg_dumpall-with-non-text_format-20th_feb.patch
Description: Binary data
