On Mon, 17 Feb 2025 at 09:49, Peter Smith <smithpb2...@gmail.com> wrote: > > Hi Shubham > > Some review comments for v7-0001. > > (I am late to this thread. If some of my comments have already been > discussed and rejected please let me know). > > ====== > 1 GENERAL. Option Name? > > Wondering why the patch is introducing more terminology like > "cleanup"; if we are dropping publications then why not say "drop"? > Also I am not sure if "existing" means anything because you cannot > cleanup/drop something that is not "existing". > > IOW, why not call this the "--drop-publications" option?
We should keep this option generic as this same option should be enhanced further to handle cleaning other objects which was suggested earlier at [1]. How about something like: remove-non-logical-objects/clean-non-logical-objects/purge-non-replicated/discard-non-replicated or something better? [1] - https://www.postgresql.org/message-id/CAExHW5t4ew7ZrgcDdTv7YmuG7LVQT1ZaEny_EvtngHtEBNyjcQ%40mail.gmail.com Regards, Vignesh
