On Tue, Feb 4, 2025 at 10:45 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Mon, Feb 3, 2025 at 6:35 PM Shlok Kyal <shlok.kyal....@gmail.com> wrote: > > > > I reviewed the v66 patch. I have few comments: > > > > 1. I also feel the default value should be set to '0' as suggested by > > Vignesh in 1st point of [1]. > > > > +1. This will ensure that the idle slots won't be invalidated by > default, the same as HEAD. We can change the default value based on > user inputs. >
Here are the v68 patches, incorporating above as well as comments from [1]. Note: The 0003 patch with tests under PG_EXTRA_TESTS is not included for now. If needed, I'll send it later once the first two patches are committed. [1] https://www.postgresql.org/message-id/CAHut%2BPv3mjQxmv5tHfgX%3Do%3D4C2TfX5rNYGS7xWrHBGcSVwr3mQ%40mail.gmail.com -- Thanks, Nisha
v68-0001-Introduce-inactive_timeout-based-replication-slo.patch
Description: Binary data
v68-0002-Add-TAP-test-for-slot-invalidation-based-on-inac.patch
Description: Binary data
