On Tue, Jan 21, 2025 at 02:17:03PM +0000, Dagfinn Ilmari Mannsåker wrote: > Thanks again for reviewing this monster patch.
+$node->command_checks_all( + [ 'pg_amcheck', '--exclude-user' => 'no_such_user', 'postgres' ], Extra error spotted here with s/--exclude-user/--username/. The double --verbose for test 'run pg_createsubscriber on node S' is intentional, as mentioned by Euler. Fixed this one by making the two --verbose be side-by-side, and added a comment to document the intention. Perhaps pg_resetwal/t/001_basic.pl should also use more long option names? Note that there are a few more under "Locale provider tests" in the initdb tests. I've left that as a follow-up thing, that was already a lot.. Found some more inconsistencies with the ordering of the options, like a few start commands with pg_ctl in the recovery tests. I've maintained some consistency here, even if your patch was OK. -- Michael
signature.asc
Description: PGP signature
