Dear David,

> As none of those programs "create" a database the wording "The default is to
> create a database" seems quite a poor choice to standardize on.

Oh, I misunderstood. Sorry. I wanted to suggest like below:

```
The default is to connect to a database with the same name as the current system
user.
````

My main point was we should clarify that the OS (system) user-name is used.

> "connection to default database failed" is a strictly worse error message 
> than the
> existing one used unconditionally.
> There probably should still be the existing "else" block in the other hunk - 
> we do
> default to OS user name - but to handle -U shouldn't we just add an "else if 
> (username)
> ...block before it?

You meant like attached, right? It seems simpler than my idea.

PSA updated version.

----------
Best regards,
Hayato Kuroda

Attachment: v2-0001-pgbench-Use-default-connection-when-dbname-is-not.patch
Description: v2-0001-pgbench-Use-default-connection-when-dbname-is-not.patch

Attachment: v2-0002-Unify-descriptions-when-dbname-is-not-specified.patch
Description: v2-0002-Unify-descriptions-when-dbname-is-not-specified.patch

Reply via email to