On Thu, Jan 16, 2025 at 8:15 AM Nathan Bossart <nathandboss...@gmail.com> wrote: > On Tue, Jan 14, 2025 at 11:08:05PM -0500, Tom Lane wrote: > > Nathan Bossart <nathandboss...@gmail.com> writes: > >> My guess is that this has something to do with redefining SIG_ERR in > >> win32_port.h. We might be able to use push_macro/pop_macro to keep the old > >> value around, but at the moment I'm leaning towards just removing the > >> assertion in that path. > > > > I wonder why we redefine those values? > > I wondered the same. Those redefines have been there since commit 5049196, > but I haven't been able to find any real discussion in the archives about > it. Maybe I will bug Magnus about it sometime, in case he happens to > remember the reason.
My guess would be: perhaps some ancient version of MinGW didn't define them? They're defined by MinGW and native signal.h now and they have the same values, so we should remove them I think. Assertion failed: 0, file ../src/port/pqsignal.c, line 147 Could be due to calling native signal() with a signal number other than the 6 values required to work by the C standard?
