On Tue, Jan 14, 2025 at 10:02:46PM -0500, Tom Lane wrote: > LGTM, although I don't know enough about Windows to know if the > "== SIG_ERR" test in that path is correct.
It's apparently not [0]. :( My guess is that this has something to do with redefining SIG_ERR in win32_port.h. We might be able to use push_macro/pop_macro to keep the old value around, but at the moment I'm leaning towards just removing the assertion in that path. [0] https://cirrus-ci.com/task/6237809813487616 -- nathan
