Hi Shubham.
The patch v6-0001 LGTM.
OTOH, if you want to be picky, the docs wording could be slightly
modified to be more consistent with the coded warning message.
CURRENT
Replication failures can occur if required WAL files are prematurely
deleted. To prevent this, the source server must set <xref
linkend="guc-max-slot-wal-keep-size"/> to <literal>-1</literal>,
ensuring WAL files are not automatically removed.
SUGGESTION
Replication failures can occur if required WAL files are missing. To
prevent this, the source server must set <xref
linkend="guc-max-slot-wal-keep-size"/> to <literal>-1</literal> to
ensure that required WAL files are not prematurely removed.
~~~
See the attached NITPICKS diff if you want to make this change.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
diff --git a/doc/src/sgml/ref/pg_createsubscriber.sgml
b/doc/src/sgml/ref/pg_createsubscriber.sgml
index c5ee5f4..40b8fac 100644
--- a/doc/src/sgml/ref/pg_createsubscriber.sgml
+++ b/doc/src/sgml/ref/pg_createsubscriber.sgml
@@ -315,10 +315,10 @@ PostgreSQL documentation
</para>
<para>
- Replication failures can occur if required WAL files are prematurely
deleted.
- To prevent this, the source server must set <xref
- linkend="guc-max-slot-wal-keep-size"/> to <literal>-1</literal>, ensuring
- WAL files are not automatically removed.
+ Replication failures can occur if required WAL files are missing. To prevent
+ this, the source server must set <xref
linkend="guc-max-slot-wal-keep-size"/>
+ to <literal>-1</literal> to ensure that required WAL files are not
+ prematurely removed.
</para>
</refsect2>
