On 17.12.24 01:46, Andreas Karlsson wrote:
On 12/16/24 8:39 AM, Peter Eisentraut wrote:
I'll leave it at this for now and wait for some reviews.
I really like this work since it makes the code cleaner to read on top
of paving the way for threading.
Reviewed the patches and found a couple of issues.
- Shouldn't yyext in syncrep_scanner_init() be allocated on the heap? Or
at least on the stack but by the caller?
I think it's correct the way it is. It's only a temporary space for the
scanner, so we can allocate it in the innermost scope.
- I think you have flipped the parameters of replication_yyerror(), see
attached fixup patch.
Good catch. There was also a similar issue with syncrep_yyerror().
- Some white space issues fixed in an attached fixup patch.
committed
- Also fixed the static remaining variables in the replication parser in
an attached patch.
Thanks, I'll take a look at that.
- There seems to be a lot left to do to make the plpgsql scanner
actually re-entrant so I do not think it would makes sense to commit the
patch which sets the re-entrant option before that is done.
Ok, we can hold that one back until the full stack including the parser
is done.
