Dear Shubham,
> Thank you for pointing this out and for suggesting the changes. I
> agree with your approach.
> Also, I found a mistake in getopt_long and fixed it in this version of
> the patch.
> The attached patch contains the suggested changes.
Thanks for updating the patch. I think the patch looks mostly OK.
Regarding the test code - I think we should directly refer the pg_subscription
catalog,
and confirm that subtwophase is 'p'. IIUC, we can wait until
all subscriptions. Subtwophasestate are 'e', by using poll_query_until() and
[1].
[1]: SELECT count(1) = 0 FROM pg_subscription WHERE subtwophasestate NOT IN
('e');
Best regards,
Hayato Kuroda
FUJITSU LIMITED
