Dear Shubham, Thanks for the proposal!
> I am writing to propose the addition of the two_phase option in > pg_createsubscriber. As discussed in [1], supporting this feature > during the development of pg_createsubscriber was planned for this > version. Yes, that was the pending item. > The attached patch has the changes for the same. There are API related comments. 01. I think the two-phase should be off by default. Because default value for CREATE SUBSCRIPTION command is off, and your patch breaks pre-existing style. 02. API style should be changed: no need to require the argument. I think it is enough to provide "enable-twophase" and "T" option which specify the two_phase to true. Best regards, Hayato Kuroda FUJITSU LIMITED
