Hi Nisha, here are my review comments for the patch v51-0001. ====== src/backend/replication/slot.c
ReplicationSlotAcquire:
1.
+ ereport(ERROR,
+ errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
+ errmsg("can no longer get changes from replication slot \"%s\"",
+ NameStr(s->data.name)),
+ errdetail_internal("%s", err_detail.data));
+
+ pfree(err_detail.data);
+ }
+
Won't the 'pfree' be unreachable due to the prior ereport ERROR?
======
Kind Regards,
Peter Smith.
Fujitsu Australia
