On Wed, Nov 20, 2024 at 1:29 PM vignesh C <vignes...@gmail.com> wrote: > > On Tue, 19 Nov 2024 at 12:43, Nisha Moond <nisha.moond...@gmail.com> wrote: > > > > Attached is the v49 patch set: > > - Fixed the bug reported in [1]. > > - Addressed comments in [2] and [3]. > > > > I've split the patch into two, implementing the suggested idea in > > comment #5 of [2] separately in 001: > > > > Patch-001: Adds additional error reports (for all invalidation types) > > in ReplicationSlotAcquire() for invalid slots when error_if_invalid = > > true. > > Patch-002: The original patch with comments addressed. > > This Assert can fail: >
Attached v50 patch-set addressing review comments in [1] and [2]. Regarding the assert issue reported in [2]: - For temporary replication slots, the current session's pid serves as the active_pid for the slot, which is expected behavior. - Therefore, the ASSERT has been removed in v50. Now, if a temporary slot qualifies for a timeout invalidation, the holding process will be terminated, and the slot will be invalidated. [1] https://www.postgresql.org/message-id/CALDaNm2UUTfJczjR-rEQwKgmx%3DiFnuMnR1cXv7ccB%2BO9P15mYg%40mail.gmail.com [2] https://www.postgresql.org/message-id/CALDaNm0g86wD2%3DbQdFOy0smsP0MZWyz0CUqXej%3DQi-hCEeqkag%40mail.gmail.com -- Thanks, Nisha
v50-0001-Add-error-handling-while-acquiring-a-replication.patch
Description: Binary data
v50-0002-Introduce-inactive_timeout-based-replication-slo.patch
Description: Binary data
