> On 14 Nov 2024, at 11:55, Daniil Davydov <3daniss...@gmail.com> wrote:
>
> On Wed, Oct 30, 2024 at 7:32 PM Rafia Sabih <rafia.pghack...@gmail.com> wrote:
>
>> Good catch. I agree with this being an unwarranted behaviour.
>> A minor comment from my end is the wording of the error message.
>> Based on the Postgresql error message style huide, something like this could
>> be better,
>> "could not access temporary relations of other sessions".
>> --
>> Regards,
>> Rafia Sabih
>> CYBERTEC PostgreSQL International GmbH
>>
> Thanks for your comment. I attach a patch with a fixed error message.
> Also you can find it in commit fest
> (https://commitfest.postgresql.org/51/5379/)
I suspect that protection of temp tables was broken by 00d1e02be249. And I'd
suggest fixing it in a line with how it worked before. Changes to locking
mechanism is kind of a super subtle matters, it is really hard to bring this
checks here without breaking something else. Maybe not immidiately. but still.
I'd suggest fixing somewhere around RelationAddBlocks(). But be sure to check
all code pathes that lead to this check.
Also, having an isolation test is nice. But do we actually do isolation tests
with PL\pgSQL?
Thanks!
Best regards, Andrey Borodin.
