On Tue, Nov 19, 2024 at 05:40:20PM -0500, Bruce Momjian wrote: > On Tue, Nov 19, 2024 at 03:47:20PM -0500, Corey Huinker wrote: > > * create a pg_stats_health_check script that lists tables missing stats, > > with > > --fix/--fix-in-stages options, effectively replacing vacuumdb for those > > purposes, and then crank up the messaging about that change. The "new shiny" > > effect of a new utility that has "stats", "health", and "check" in the name > > may > > be the search/click-bait we need to get the word out effectively. That last > > sentence may sound facetious, but it isn't, it's just accepting how search > > engines and eyeballs currently function. With that in place, we can then > > change > > the vacuumdb documentation to be deter future use in post-upgrade > > situations. > > We used to create a script until the functionality was added to > vacuumdb. Since 99% of users will not need to do anything after > pg_upgrade, it would make sense to output the script only for the 1% of > users who need it and tell users to run it, rather than giving > instructions that are a no-op for 99% of users.
One problem with the above approach is that it gives users upgrading or loading via pg_dump no way to know which tables need analyze statistics, right? I think that is why we ended up putting the pg_upgrade statistics functionality in vacuumdb --analyze-in-stages. -- Bruce Momjian <br...@momjian.us> https://momjian.us EDB https://enterprisedb.com When a patient asks the doctor, "Am I going to die?", he means "Am I going to die soon?"
