On Thu, Oct 31, 2024 at 1:14 PM vignesh C <vignes...@gmail.com> wrote: > > On Thu, 31 Oct 2024 at 04:42, Peter Smith <smithpb2...@gmail.com> wrote: > > > > On Thu, Oct 31, 2024 at 3:16 AM vignesh C <vignes...@gmail.com> wrote: > > > > > > On Wed, 30 Oct 2024 at 15:06, Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > > > On Tue, Oct 29, 2024 at 8:50 PM vignesh C <vignes...@gmail.com> wrote: > > > > > > > > > > Thank you for reporting this issue. The attached v46 patch addresses > > > > > the problem and includes some adjustments to the comments. Thanks to > > > > > Amit for sharing the comment changes offline. > > > > > > > > > > > > > Pushed. Kindly rebase and send the remaining patches. > > > > > > Thanks for committing this patch, here is a rebased version of the > > > remaining patches. > > > > > > > Hi, > > > > I found that the docs of src/sgml/ddl.sgml [1] are still saying: > > > > <para> > > Generated columns are skipped for logical replication and cannot be > > specified in a <command>CREATE PUBLICATION</command> column list. > > </para> > > > > But that is contrary to the new behaviour after the "Replicate > > generated columns when specified in the column list." commit yesterday > > [2]. > > > > It looks like an oversight. I think updating that paragraph should > > have been included with yesterday's commit. > > Thanks for the findings, the attached patch has the changes for the same. >
LGTM. ====== Kind Regards, Peter Smith. Fujitsu Australia
