On Thu, 31 Oct 2024 at 04:42, Peter Smith <smithpb2...@gmail.com> wrote:
>
> On Thu, Oct 31, 2024 at 3:16 AM vignesh C <vignes...@gmail.com> wrote:
> >
> > On Wed, 30 Oct 2024 at 15:06, Amit Kapila <amit.kapil...@gmail.com> wrote:
> > >
> > > On Tue, Oct 29, 2024 at 8:50 PM vignesh C <vignes...@gmail.com> wrote:
> > > >
> > > > Thank you for reporting this issue. The attached v46 patch addresses
> > > > the problem and includes some adjustments to the comments. Thanks to
> > > > Amit for sharing the comment changes offline.
> > > >
> > >
> > > Pushed. Kindly rebase and send the remaining patches.
> >
> > Thanks for committing this patch, here is a rebased version of the
> > remaining patches.
> >
>
> Hi,
>
> I found that the docs of src/sgml/ddl.sgml [1] are still saying:
>
> <para>
> Generated columns are skipped for logical replication and cannot be
> specified in a <command>CREATE PUBLICATION</command> column list.
> </para>
>
> But that is contrary to the new behaviour after the "Replicate
> generated columns when specified in the column list." commit yesterday
> [2].
>
> It looks like an oversight. I think updating that paragraph should
> have been included with yesterday's commit.
Thanks for the findings, the attached patch has the changes for the same.
Regards,
Vignesh
From 6cf390c33d1b88836da2ec0753562568b20b39e1 Mon Sep 17 00:00:00 2001
From: Vignesh C <vignes...@gmail.com>
Date: Thu, 31 Oct 2024 07:36:37 +0530
Subject: [PATCH] Update documentation for generated columns in logical
replication
The previous commit (745217a051) introduced support for logical
replication of generated columns when specified alongside a column
list. However, the documentation for generated columns was not updated
to reflect this change. This commit addresses that oversight by adding
clarification on the support for generated columns in the logical
replication section.
---
doc/src/sgml/ddl.sgml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/ddl.sgml b/doc/src/sgml/ddl.sgml
index f6344b3b79..f02f67d7b8 100644
--- a/doc/src/sgml/ddl.sgml
+++ b/doc/src/sgml/ddl.sgml
@@ -514,8 +514,9 @@ CREATE TABLE people (
</listitem>
<listitem>
<para>
- Generated columns are skipped for logical replication and cannot be
- specified in a <command>CREATE PUBLICATION</command> column list.
+ Generated columns can be replicated during logical replication by
+ including them in the column list of the
+ <command>CREATE PUBLICATION</command> command.
</para>
</listitem>
</itemizedlist>
--
2.34.1
