> > This seems like a reasonable refactoring exercise that we could take care > of before the rest of the patch set goes in. I added one new reference to > dopt.schemaOnly in commit bd15b7d, so that should probably be revised to > !dumpData, too. I also noticed a few references to dataOnly/schemaOnly in > comments that should likely be adjusted. >
I'll be on the lookout for the new usage with the next rebase, and will fix the comments as well. > One other question I had when looking at this patch is whether we could > remove dataOnly/schemaOnly from DumpOptions and RestoreOptions. Once 0007 > is applied, those variables become particularly hazardous, so we really > want to prevent folks from using them in new code. Well, the very next patch in the series adds --statistics-only, so I don't think we're getting rid of user-facing command switches. However, I could see us taking away the dataOnly/schemaOnly internal variables, thus preventing coders from playing with those sharp objects.
