Hi!
On 10.10.2024 15:43, David Rowley wrote:
On Tue, 8 Oct 2024 at 04:14, Robert Haas<robertmh...@gmail.com> wrote:
I think you have adequate consensus to proceed with this. I'd just ask
that you don't disappear completely if it turns out that there are
problems. I accept that my commit created this problem and I'm
certainly willing to be involved too if we need to sort out more
things.
Thanks. I've attached a polished-up version of the earlier patch.
I spent quite a bit of time testing it by manually adjusting
disabled_nodes while attached with my debugger. Doing it that way was
easier as it's often hard and maybe sometimes not possible to get the
disabled node you want in a plan.
I'll loop back to the documentation part and Laruenz's patch after
this part is committed.
If anyone wants to take a look at the attached, please do so.
Otherwise, I'm pretty happy with it and will likely push it on New
Zealand Friday (aka later today).
David
I think you missed some previous output and we should fix that.
--
Regards,
Alena Rybakina
Postgres Professional
diff --git a/src/test/regress/expected/collate.icu.utf8.out b/src/test/regress/expected/collate.icu.utf8.out
index 31345295c11..faa376e060c 100644
--- a/src/test/regress/expected/collate.icu.utf8.out
+++ b/src/test/regress/expected/collate.icu.utf8.out
@@ -989,7 +989,7 @@ select * from collate_test1 where b ilike 'abc';
QUERY PLAN
-------------------------------
Seq Scan on collate_test1
- Disabled Nodes: 1
+ Disabled: true
Filter: (b ~~* 'abc'::text)
(3 rows)
@@ -1005,7 +1005,7 @@ select * from collate_test1 where b ilike 'ABC';
QUERY PLAN
-------------------------------
Seq Scan on collate_test1
- Disabled Nodes: 1
+ Disabled: true
Filter: (b ~~* 'ABC'::text)
(3 rows)
