On Tue, Sep 24, 2024 at 02:26:08PM -0500, Nathan Bossart wrote: > On Tue, Sep 24, 2024 at 01:21:45PM +0900, Michael Paquier wrote: >> On Mon, Sep 23, 2024 at 10:50:21AM -0500, Nathan Bossart wrote: >>> I carefully inspected all the code paths this patch touches, and I think >>> I've got all the details right, but I would be grateful if someone else >>> could take a look. >> >> No objections from here with putting the snapshots pops and pushes >> outside the inner routines of reindex/drop concurrently, meaning that >> ReindexRelationConcurrently(), DefineIndex() and index_drop() are fine >> to do these operations. > > Great. I plan to push 0001 shortly.
Committed this one. -- nathan