On Tue, Oct 15, 2024 at 08:20:17PM -0500, Nathan Bossart wrote: > On Wed, Oct 16, 2024 at 09:12:31AM +0900, Michael Paquier wrote: > > - if (!ctx->rel->rd_rel->reltoastrelid) > > + if (!OidIsValid(RelationGetToastRelid(ctx->rel))) > > > > This set of diffs in 0002 is a nice cleanup. I'd wish for relying > > less on zero comparitons when assuming that InvalidOid is in use. > > I'm wondering if there's any concern about this one causing back-patching > pain. If so, I can just add the macro for use in new code.
This bit does not concern me much. manipulations of reltoastrelid from Relations are not that common in bug fixes. > I assume all of this will get compiled out in non-USE_ASSERT_CHECKING > builds as-is, but I see no problem with surrounding it with an #ifdef to be > sure. Yeah, I'm not sure that that would always be the case when optimized. Code generated can be dumb sometimes even if compilers got much smarter in the last 10 years or so (not compiler guy here). -- Michael
signature.asc
Description: PGP signature
