>I noticed one more thing: pg_dumpall.c doesn't really need to prohibit >--on-conflict-do-nothing without --insert. Its existing validation rejects >illegal >combinations of the settings that are *not* passed on to pg_dump. It seems OK >to >just pass those on and let pg_dump complain. For example, if you say >"pg_dumpall >--data-only --schema-only", it's pg_dump that complains, not pg_dumpall. I >think we >should do the same thing here.
Thank you for the clarification. I didn't give thought to pg_dumpall internally running pg_dump. >Pushed, with those changes. Thanks!
