On Fri, Sep 13, 2024 at 3:02 PM Tatsuo Ishii <is...@postgresql.org> wrote: > > > The patch looks fine but it doesn't add a test case where Storage is > > Disk > > We can test the case by setting work_mem to the minimum size (64kB) > and giving slightly larger "stop" parameter to generate_series. >
WFM > > or the case when the last usage fit in memory but an earlier > > usage spilled to disk. > > In my understanding once tuplestore changes the storage type to disk, > it never returns to the memory storage type in terms of > tuplestore_get_stats. i.e. once state->usedDisk is set to true, it > never goes back to false. So the test case is not necessary. > David, am I correct? I understand that. I am requesting a testcase to test that same logic. -- Best Wishes, Ashutosh Bapat
