> The patch looks fine but it doesn't add a test case where Storage is > Disk
We can test the case by setting work_mem to the minimum size (64kB) and giving slightly larger "stop" parameter to generate_series. > or the case when the last usage fit in memory but an earlier > usage spilled to disk. In my understanding once tuplestore changes the storage type to disk, it never returns to the memory storage type in terms of tuplestore_get_stats. i.e. once state->usedDisk is set to true, it never goes back to false. So the test case is not necessary. David, am I correct? > Do we want to cover those. This test would be > the only one where those code paths could be tested. I am fine to add the first test case. Best reagards, -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp
