Hi, I normally build the code with warnings enabled (specifically, -Wshadow) which exposes many "shadowed" declarations.
It would be better to reduce warnings wherever it's easy to do so, because if we always see/ignore lots of warnings then sooner or later something important may escape attention. In any case, just removing these warnings sometimes makes the code more readable by removing any ambiguity. Currently, I'm seeing 350+ shadow warnings. See the attached summary. It will be WIP to eliminate them all, but here is a patch to address some of the low-hanging fruit. If the patch is accepted, then I can try later to deal with more of them. ====== The following are fixed by changing the param/var from 'text' to 'txt'. execute.c:111:19: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] ~ prepare.c:104:26: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] prepare.c:270:12: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] ~ c_keywords.c:36:32: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] ecpg_keywords.c:39:35: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] ~ tab-complete.c:1638:29: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5082:46: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5111:38: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5120:36: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5129:37: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5140:33: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5148:43: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5164:40: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5172:50: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5234:19: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5605:32: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5685:33: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5733:37: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5778:33: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5910:27: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] ====== The following was fixed by changing the name of the global static from 'progname' to 'prog_name'. pg_createsubscriber.c:341:46: warning: declaration of ‘progname’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:114:20: warning: shadowed declaration is here [-Wshadow] ~ The following was fixed by changing the name of the global static from 'dbinfo' to 'db_info'. pg_createsubscriber.c:437:25: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:734:40: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:841:46: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:961:47: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1104:41: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1142:41: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1182:45: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1242:54: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1272:56: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1314:70: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1363:60: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1553:57: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1627:55: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1681:64: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1739:69: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1830:64: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] ====== Kind Regards, Peter Smith. Fujitsu Australia
controldata_utils.c:52:29: warning: declaration of ‘DataDir’ shadows a global declaration [-Wshadow] ../../src/include/miscadmin.h:172:26: warning: shadowed declaration is here [-Wshadow] controldata_utils.c:189:32: warning: declaration of ‘DataDir’ shadows a global declaration [-Wshadow] ../../src/include/miscadmin.h:172:26: warning: shadowed declaration is here [-Wshadow] brin.c:685:16: warning: declaration of ‘tmp’ shadows a previous local [-Wshadow] brin.c:579:11: warning: shadowed declaration is here [-Wshadow] gistbuild.c:1159:23: warning: declaration of ‘splitinfo’ shadows a previous local [-Wshadow] gistbuild.c:1059:11: warning: shadowed declaration is here [-Wshadow] xlogdesc.c:40:26: warning: declaration of ‘wal_level’ shadows a global declaration [-Wshadow] ../../../../src/include/access/xlog.h:96:24: warning: shadowed declaration is here [-Wshadow] xlogdesc.c:165:9: warning: declaration of ‘wal_level’ shadows a global declaration [-Wshadow] ../../../../src/include/access/xlog.h:96:24: warning: shadowed declaration is here [-Wshadow] xlogreader.c:106:24: warning: declaration of ‘wal_segment_size’ shadows a global declaration [-Wshadow] ../../../../src/include/access/xlog.h:37:24: warning: shadowed declaration is here [-Wshadow] xlogrecovery.c:1210:13: warning: declaration of ‘backupEndRequired’ shadows a global declaration [-Wshadow] xlogrecovery.c:284:13: warning: shadowed declaration is here [-Wshadow] xlogrecovery.c:1920:33: warning: declaration of ‘xlogreader’ shadows a global declaration [-Wshadow] xlogrecovery.c:189:25: warning: shadowed declaration is here [-Wshadow] xlogrecovery.c:3144:28: warning: declaration of ‘xlogprefetcher’ shadows a global declaration [-Wshadow] xlogrecovery.c:192:24: warning: shadowed declaration is here [-Wshadow] xlogrecovery.c:3148:19: warning: declaration of ‘xlogreader’ shadows a global declaration [-Wshadow] xlogrecovery.c:189:25: warning: shadowed declaration is here [-Wshadow] xlogrecovery.c:3311:31: warning: declaration of ‘xlogreader’ shadows a global declaration [-Wshadow] xlogrecovery.c:189:25: warning: shadowed declaration is here [-Wshadow] xlogrecovery.c:4062:38: warning: declaration of ‘xlogprefetcher’ shadows a global declaration [-Wshadow] xlogrecovery.c:192:24: warning: shadowed declaration is here [-Wshadow] basebackup_incremental.c:601:14: warning: declaration of ‘i’ shadows a previous local [-Wshadow] basebackup_incremental.c:275:8: warning: shadowed declaration is here [-Wshadow] objectaddress.c:2135:12: warning: declaration of ‘nulls’ shadows a previous local [-Wshadow] objectaddress.c:2114:8: warning: shadowed declaration is here [-Wshadow] objectaddress.c:2152:12: warning: declaration of ‘nulls’ shadows a previous local [-Wshadow] objectaddress.c:2114:8: warning: shadowed declaration is here [-Wshadow] objectaddress.c:2189:12: warning: declaration of ‘nulls’ shadows a previous local [-Wshadow] objectaddress.c:2114:8: warning: shadowed declaration is here [-Wshadow] parse_target.c:1610:13: warning: declaration of ‘levelsup’ shadows a parameter [-Wshadow] parse_target.c:1519:56: warning: shadowed declaration is here [-Wshadow] parse_target.c:1668:13: warning: declaration of ‘levelsup’ shadows a parameter [-Wshadow] parse_target.c:1519:56: warning: shadowed declaration is here [-Wshadow] extension.c:1024:13: warning: declaration of ‘schemaName’ shadows a parameter [-Wshadow] extension.c:818:20: warning: shadowed declaration is here [-Wshadow] schemacmds.c:208:12: warning: declaration of ‘stmt’ shadows a parameter [-Wshadow] schemacmds.c:52:39: warning: shadowed declaration is here [-Wshadow] statscmds.c:288:16: warning: declaration of ‘attnums’ shadows a previous local [-Wshadow] statscmds.c:64:9: warning: shadowed declaration is here [-Wshadow] tablecmds.c:13929:20: warning: declaration of ‘cmd’ shadows a parameter [-Wshadow] tablecmds.c:13838:67: warning: shadowed declaration is here [-Wshadow] tablecmds.c:14002:20: warning: declaration of ‘cmd’ shadows a parameter [-Wshadow] tablecmds.c:13838:67: warning: shadowed declaration is here [-Wshadow] trigger.c:1163:13: warning: declaration of ‘qual’ shadows a previous local [-Wshadow] trigger.c:186:11: warning: shadowed declaration is here [-Wshadow] execExprInterp.c:408:27: warning: declaration of ‘dispatch_table’ shadows a global declaration [-Wshadow] execExprInterp.c:112:21: warning: shadowed declaration is here [-Wshadow] nodeAgg.c:3977:20: warning: declaration of ‘phase’ shadows a previous local [-Wshadow] nodeAgg.c:3187:8: warning: shadowed declaration is here [-Wshadow] nodeValuesscan.c:144:16: warning: declaration of ‘estate’ shadows a previous local [-Wshadow] nodeValuesscan.c:50:13: warning: shadowed declaration is here [-Wshadow] be-secure-common.c:114:44: warning: declaration of ‘ssl_key_file’ shadows a global declaration [-Wshadow] ../../../src/include/libpq/libpq.h:91:26: warning: shadowed declaration is here [-Wshadow] main.c:216:27: warning: declaration of ‘progname’ shadows a global declaration [-Wshadow] main.c:44:13: warning: shadowed declaration is here [-Wshadow] main.c:320:18: warning: declaration of ‘progname’ shadows a global declaration [-Wshadow] main.c:44:13: warning: shadowed declaration is here [-Wshadow] main.c:379:24: warning: declaration of ‘progname’ shadows a global declaration [-Wshadow] main.c:44:13: warning: shadowed declaration is here [-Wshadow] equivclass.c:727:16: warning: declaration of ‘rel’ shadows a parameter [-Wshadow] equivclass.c:593:15: warning: shadowed declaration is here [-Wshadow] createplan.c:1248:12: warning: declaration of ‘plan’ shadows a previous local [-Wshadow] createplan.c:1219:13: warning: shadowed declaration is here [-Wshadow] createplan.c:2558:12: warning: declaration of ‘plan’ shadows a previous local [-Wshadow] createplan.c:2548:13: warning: shadowed declaration is here [-Wshadow] partdesc.c:229:16: warning: declaration of ‘key’ shadows a previous local [-Wshadow] partdesc.c:149:15: warning: shadowed declaration is here [-Wshadow] dependencies.c:375:23: warning: declaration of ‘DependencyGenerator’ shadows a global declaration [-Wshadow] dependencies.c:65:34: warning: shadowed declaration is here [-Wshadow] dependencies.c:1192:14: warning: declaration of ‘expr’ shadows a parameter [-Wshadow] dependencies.c:1168:87: warning: shadowed declaration is here [-Wshadow] dependencies.c:1226:22: warning: declaration of ‘expr’ shadows a parameter [-Wshadow] dependencies.c:1168:87: warning: shadowed declaration is here [-Wshadow] extended_stats.c:1046:10: warning: declaration of ‘isnull’ shadows a previous local [-Wshadow] extended_stats.c:998:11: warning: shadowed declaration is here [-Wshadow] bufmgr.c:1206:11: warning: declaration of ‘flags’ shadows a previous local [-Wshadow] bufmgr.c:1196:8: warning: shadowed declaration is here [-Wshadow] date.c:507:9: warning: declaration of ‘days’ shadows a global declaration [-Wshadow] ../../../../src/include/utils/datetime.h:261:38: warning: shadowed declaration is here [-Wshadow] date.c:531:9: warning: declaration of ‘days’ shadows a global declaration [-Wshadow] ../../../../src/include/utils/datetime.h:261:38: warning: shadowed declaration is here [-Wshadow] datetime.c:635:8: warning: declaration of ‘days’ shadows a global declaration [-Wshadow] datetime.c:84:19: warning: shadowed declaration is here [-Wshadow] formatting.c:3290:25: warning: declaration of ‘months’ shadows a global declaration [-Wshadow] ../../../../src/include/utils/datetime.h:259:38: warning: shadowed declaration is here [-Wshadow] jsonpath_exec.c:539:17: warning: declaration of ‘found’ shadows a previous local [-Wshadow] jsonpath_exec.c:528:11: warning: shadowed declaration is here [-Wshadow] jsonpath_exec.c:1899:24: warning: declaration of ‘res’ shadows a previous local [-Wshadow] jsonpath_exec.c:1800:15: warning: shadowed declaration is here [-Wshadow] jsonpath_exec.c:1910:24: warning: declaration of ‘res’ shadows a previous local [-Wshadow] jsonpath_exec.c:1800:15: warning: shadowed declaration is here [-Wshadow] jsonpath_exec.c:2086:17: warning: declaration of ‘res’ shadows a previous local [-Wshadow] jsonpath_exec.c:2048:21: warning: shadowed declaration is here [-Wshadow] jsonpath_exec.c:4142:16: warning: declaration of ‘state’ shadows a parameter [-Wshadow] jsonpath_exec.c:4115:41: warning: shadowed declaration is here [-Wshadow] pg_upgrade_support.c:230:13: warning: declaration of ‘extName’ shadows a previous local [-Wshadow] pg_upgrade_support.c:187:11: warning: shadowed declaration is here [-Wshadow] timestamp.c:1532:9: warning: declaration of ‘months’ shadows a global declaration [-Wshadow] ../../../../src/include/utils/datetime.h:259:38: warning: shadowed declaration is here [-Wshadow] timestamp.c:1534:9: warning: declaration of ‘days’ shadows a global declaration [-Wshadow] ../../../../src/include/utils/datetime.h:261:38: warning: shadowed declaration is here [-Wshadow] timestamp.c:2467:9: warning: declaration of ‘days’ shadows a global declaration [-Wshadow] ../../../../src/include/utils/datetime.h:261:38: warning: shadowed declaration is here [-Wshadow] timestamp.c:6078:11: warning: declaration of ‘val’ shadows a previous local [-Wshadow] timestamp.c:5939:5: warning: shadowed declaration is here [-Wshadow] varlena.c:4160:13: warning: declaration of ‘chunk_start’ shadows a previous local [-Wshadow] varlena.c:4095:15: warning: shadowed declaration is here [-Wshadow] varlena.c:5786:14: warning: declaration of ‘str’ shadows a previous local [-Wshadow] varlena.c:5621:17: warning: shadowed declaration is here [-Wshadow] inval.c:360:31: warning: declaration of ‘msg’ shadows a previous local [-Wshadow] inval.c:444:28: warning: shadowed declaration is here [-Wshadow] inval.c:360:31: warning: declaration of ‘msg’ shadows a previous local [-Wshadow] inval.c:476:28: warning: shadowed declaration is here [-Wshadow] inval.c:376:31: warning: declaration of ‘msgs’ shadows a parameter [-Wshadow] inval.c:882:66: warning: shadowed declaration is here [-Wshadow] inval.c:376:31: warning: declaration of ‘msgs’ shadows a parameter [-Wshadow] inval.c:882:66: warning: shadowed declaration is here [-Wshadow] inval.c:376:31: warning: declaration of ‘msgs’ shadows a parameter [-Wshadow] inval.c:882:66: warning: shadowed declaration is here [-Wshadow] inval.c:376:31: warning: declaration of ‘msgs’ shadows a parameter [-Wshadow] inval.c:882:66: warning: shadowed declaration is here [-Wshadow] freepage.c:1589:9: warning: declaration of ‘result’ shadows a previous local [-Wshadow] freepage.c:1480:28: warning: shadowed declaration is here [-Wshadow] fe-connect.c:3696:11: warning: declaration of ‘res’ shadows a previous local [-Wshadow] fe-connect.c:2601:14: warning: shadowed declaration is here [-Wshadow] execute.c:111:19: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] prepare.c:104:26: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] prepare.c:270:12: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] c_keywords.c:36:32: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] descriptor.c:76:34: warning: declaration of ‘connection’ shadows a global declaration [-Wshadow] preproc_extern.h:33:14: warning: shadowed declaration is here [-Wshadow] descriptor.c:99:35: warning: declaration of ‘connection’ shadows a global declaration [-Wshadow] preproc_extern.h:33:14: warning: shadowed declaration is here [-Wshadow] descriptor.c:131:37: warning: declaration of ‘connection’ shadows a global declaration [-Wshadow] preproc_extern.h:33:14: warning: shadowed declaration is here [-Wshadow] ecpg_keywords.c:39:35: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] preproc.y:255:46: warning: declaration of ‘cur’ shadows a global declaration [-Wshadow] preproc_extern.h:47:23: warning: shadowed declaration is here [-Wshadow] preproc.y:562:48: warning: declaration of ‘initializer’ shadows a global declaration [-Wshadow] preproc.y:49:12: warning: shadowed declaration is here [-Wshadow] print.c:956:10: warning: declaration of ‘curr_nl_line’ shadows a previous local [-Wshadow] print.c:654:8: warning: shadowed declaration is here [-Wshadow] initdb.c:759:14: warning: declaration of ‘username’ shadows a global declaration [-Wshadow] initdb.c:153:14: warning: shadowed declaration is here [-Wshadow] initdb.c:989:11: warning: declaration of ‘conf_file’ shadows a global declaration [-Wshadow] initdb.c:179:14: warning: shadowed declaration is here [-Wshadow] initdb.c:2070:31: warning: declaration of ‘locale’ shadows a global declaration [-Wshadow] initdb.c:140:14: warning: shadowed declaration is here [-Wshadow] initdb.c:2133:45: warning: declaration of ‘locale’ shadows a global declaration [-Wshadow] initdb.c:140:14: warning: shadowed declaration is here [-Wshadow] initdb.c:2194:35: warning: declaration of ‘locale’ shadows a global declaration [-Wshadow] initdb.c:140:14: warning: shadowed declaration is here [-Wshadow] initdb.c:2444:19: warning: declaration of ‘progname’ shadows a global declaration [-Wshadow] initdb.c:174:20: warning: shadowed declaration is here [-Wshadow] initdb.c:2522:33: warning: declaration of ‘authmethodlocal’ shadows a global declaration [-Wshadow] initdb.c:158:20: warning: shadowed declaration is here [-Wshadow] initdb.c:2522:62: warning: declaration of ‘authmethodhost’ shadows a global declaration [-Wshadow] initdb.c:157:20: warning: shadowed declaration is here [-Wshadow] pg_amcheck.c:1181:18: warning: declaration of ‘progname’ shadows a global declaration [-Wshadow] pg_amcheck.c:140:20: warning: shadowed declaration is here [-Wshadow] pg_basebackup.c:1014:25: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.h:30:16: warning: shadowed declaration is here [-Wshadow] pg_basebackup.c:1284:30: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.h:30:16: warning: shadowed declaration is here [-Wshadow] pg_basebackup.c:1599:24: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.h:30:16: warning: shadowed declaration is here [-Wshadow] pg_basebackup.c:1698:31: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.h:30:16: warning: shadowed declaration is here [-Wshadow] pg_basebackup.c:1735:39: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.h:30:16: warning: shadowed declaration is here [-Wshadow] receivelog.c:337:22: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.h:30:16: warning: shadowed declaration is here [-Wshadow] receivelog.c:375:40: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.h:30:16: warning: shadowed declaration is here [-Wshadow] receivelog.c:453:27: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.h:30:16: warning: shadowed declaration is here [-Wshadow] receivelog.c:745:26: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.h:30:16: warning: shadowed declaration is here [-Wshadow] receivelog.c:870:24: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.h:30:16: warning: shadowed declaration is here [-Wshadow] receivelog.c:932:27: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.h:30:16: warning: shadowed declaration is here [-Wshadow] receivelog.c:986:29: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.h:30:16: warning: shadowed declaration is here [-Wshadow] receivelog.c:1040:28: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.h:30:16: warning: shadowed declaration is here [-Wshadow] receivelog.c:1171:31: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.h:30:16: warning: shadowed declaration is here [-Wshadow] receivelog.c:1211:29: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.h:30:16: warning: shadowed declaration is here [-Wshadow] streamutil.c:309:11: warning: declaration of ‘dbname’ shadows a global declaration [-Wshadow] streamutil.c:52:10: warning: shadowed declaration is here [-Wshadow] streamutil.c:344:28: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.c:55:12: warning: shadowed declaration is here [-Wshadow] streamutil.c:423:35: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.c:55:12: warning: shadowed declaration is here [-Wshadow] streamutil.c:477:27: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.c:55:12: warning: shadowed declaration is here [-Wshadow] streamutil.c:558:28: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.c:55:12: warning: shadowed declaration is here [-Wshadow] streamutil.c:652:31: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.c:55:12: warning: shadowed declaration is here [-Wshadow] streamutil.c:760:29: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.c:55:12: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:341:46: warning: declaration of ‘progname’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:114:20: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:437:25: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:734:40: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:841:46: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:961:47: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1104:41: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1142:41: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1182:45: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1242:54: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1272:56: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1314:70: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1363:60: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1553:57: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1627:55: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1681:64: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1739:69: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_createsubscriber.c:1830:64: warning: declaration of ‘dbinfo’ shadows a global declaration [-Wshadow] pg_createsubscriber.c:121:31: warning: shadowed declaration is here [-Wshadow] pg_receivewal.c:280:11: warning: declaration of ‘tli’ shadows a parameter [-Wshadow] pg_receivewal.c:268:28: warning: shadowed declaration is here [-Wshadow] pg_recvlogical.c:126:22: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.h:30:16: warning: shadowed declaration is here [-Wshadow] pg_recvlogical.c:1025:30: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.h:30:16: warning: shadowed declaration is here [-Wshadow] pg_recvlogical.c:1042:28: warning: declaration of ‘conn’ shadows a global declaration [-Wshadow] streamutil.h:30:16: warning: shadowed declaration is here [-Wshadow] pg_recvlogical.c:1042:45: warning: declaration of ‘endpos’ shadows a global declaration [-Wshadow] pg_recvlogical.c:51:19: warning: shadowed declaration is here [-Wshadow] pg_controldata.c:73:24: warning: declaration of ‘wal_level’ shadows a global declaration [-Wshadow] ../../../src/include/access/xlog.h:96:24: warning: shadowed declaration is here [-Wshadow] pg_ctl.c:875:36: warning: declaration of ‘argv0’ shadows a global declaration [-Wshadow] pg_ctl.c:93:14: warning: shadowed declaration is here [-Wshadow] pg_dump.c:1151:18: warning: declaration of ‘progname’ shadows a global declaration [-Wshadow] pg_backup_utils.h:28:20: warning: shadowed declaration is here [-Wshadow] pg_dump.c:1490:13: warning: declaration of ‘strict_names’ shadows a global declaration [-Wshadow] pg_dump.c:152:12: warning: shadowed declaration is here [-Wshadow] pg_dump.c:1549:16: warning: declaration of ‘strict_names’ shadows a global declaration [-Wshadow] pg_dump.c:152:12: warning: shadowed declaration is here [-Wshadow] pg_dump.c:1653:15: warning: declaration of ‘strict_names’ shadows a global declaration [-Wshadow] pg_dump.c:152:12: warning: shadowed declaration is here [-Wshadow] pg_dump.c:10026:15: warning: declaration of ‘comments’ shadows a global declaration [-Wshadow] pg_dump.c:197:21: warning: shadowed declaration is here [-Wshadow] pg_dump.c:10027:8: warning: declaration of ‘ncomments’ shadows a global declaration [-Wshadow] pg_dump.c:198:12: warning: shadowed declaration is here [-Wshadow] pg_dump.c:10139:15: warning: declaration of ‘comments’ shadows a global declaration [-Wshadow] pg_dump.c:197:21: warning: shadowed declaration is here [-Wshadow] pg_dump.c:10140:8: warning: declaration of ‘ncomments’ shadows a global declaration [-Wshadow] pg_dump.c:198:12: warning: shadowed declaration is here [-Wshadow] pg_dump.c:11817:15: warning: declaration of ‘comments’ shadows a global declaration [-Wshadow] pg_dump.c:197:21: warning: shadowed declaration is here [-Wshadow] pg_dump.c:11818:8: warning: declaration of ‘ncomments’ shadows a global declaration [-Wshadow] pg_dump.c:198:12: warning: shadowed declaration is here [-Wshadow] pg_restore.c:449:19: warning: declaration of ‘progname’ shadows a global declaration [-Wshadow] pg_backup_utils.h:28:20: warning: shadowed declaration is here [-Wshadow] pg_dumpall.c:1855:11: warning: declaration of ‘connstr’ shadows a global declaration [-Wshadow] pg_dumpall.c:88:14: warning: shadowed declaration is here [-Wshadow] pg_dumpall.c:1949:34: warning: declaration of ‘filename’ shadows a global declaration [-Wshadow] pg_dumpall.c:119:14: warning: shadowed declaration is here [-Wshadow] pg_resetwal.c:716:25: warning: declaration of ‘guessed’ shadows a global declaration [-Wshadow] pg_resetwal.c:64:13: warning: shadowed declaration is here [-Wshadow] file_ops.c:189:8: warning: declaration of ‘dstpath’ shadows a global declaration [-Wshadow] file_ops.c:32:13: warning: shadowed declaration is here [-Wshadow] file_ops.c:208:8: warning: declaration of ‘dstpath’ shadows a global declaration [-Wshadow] file_ops.c:32:13: warning: shadowed declaration is here [-Wshadow] file_ops.c:231:8: warning: declaration of ‘dstpath’ shadows a global declaration [-Wshadow] file_ops.c:32:13: warning: shadowed declaration is here [-Wshadow] file_ops.c:245:8: warning: declaration of ‘dstpath’ shadows a global declaration [-Wshadow] file_ops.c:32:13: warning: shadowed declaration is here [-Wshadow] file_ops.c:259:8: warning: declaration of ‘dstpath’ shadows a global declaration [-Wshadow] file_ops.c:32:13: warning: shadowed declaration is here [-Wshadow] file_ops.c:273:8: warning: declaration of ‘dstpath’ shadows a global declaration [-Wshadow] file_ops.c:32:13: warning: shadowed declaration is here [-Wshadow] pg_rewind.c:92:19: warning: declaration of ‘progname’ shadows a global declaration [-Wshadow] pg_rewind.c:63:20: warning: shadowed declaration is here [-Wshadow] pg_rewind.c:550:51: warning: declaration of ‘source’ shadows a global declaration [-Wshadow] pg_rewind.c:89:23: warning: shadowed declaration is here [-Wshadow] xlogreader.c:106:24: warning: declaration of ‘wal_segment_size’ shadows a global declaration [-Wshadow] ../../../src/include/access/xlog.h:37:24: warning: shadowed declaration is here [-Wshadow] pg_test_fsync.c:630:29: warning: declaration of ‘start_t’ shadows a global declaration [-Wshadow] pg_test_fsync.c:75:23: warning: shadowed declaration is here [-Wshadow] pg_test_fsync.c:630:53: warning: declaration of ‘stop_t’ shadows a global declaration [-Wshadow] pg_test_fsync.c:76:4: warning: shadowed declaration is here [-Wshadow] xlogdesc.c:40:26: warning: declaration of ‘wal_level’ shadows a global declaration [-Wshadow] ../../../src/include/access/xlog.h:96:24: warning: shadowed declaration is here [-Wshadow] xlogdesc.c:165:9: warning: declaration of ‘wal_level’ shadows a global declaration [-Wshadow] ../../../src/include/access/xlog.h:96:24: warning: shadowed declaration is here [-Wshadow] xlogreader.c:106:24: warning: declaration of ‘wal_segment_size’ shadows a global declaration [-Wshadow] ../../../src/include/access/xlog.h:37:24: warning: shadowed declaration is here [-Wshadow] pgbench.c:4580:11: warning: declaration of ‘skipped’ shadows a parameter [-Wshadow] pgbench.c:4548:25: warning: shadowed declaration is here [-Wshadow] describe.c:1718:17: warning: declaration of ‘myopt’ shadows a previous local [-Wshadow] describe.c:1536:16: warning: shadowed declaration is here [-Wshadow] describe.c:2242:13: warning: declaration of ‘schemaname’ shadows a parameter [-Wshadow] describe.c:1528:37: warning: shadowed declaration is here [-Wshadow] prompt.c:340:12: warning: declaration of ‘p’ shadows a previous local [-Wshadow] prompt.c:72:14: warning: shadowed declaration is here [-Wshadow] tab-complete.c:1638:29: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5082:46: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5111:38: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5120:36: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5129:37: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5140:33: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5148:43: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5164:40: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5172:50: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5234:19: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5605:32: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5685:33: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5733:37: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5778:33: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow] tab-complete.c:5910:27: warning: declaration of ‘text’ shadows a global declaration [-Wshadow] ../../../src/include/c.h:700:24: warning: shadowed declaration is here [-Wshadow]
v1-0001-Remove-some-shadowed-declarations.patch
Description: Binary data
