On Thu, Aug 15, 2024 at 5:34 PM Nathan Bossart <nathandboss...@gmail.com>
wrote:

> Now to 0002...
>
> -               if (-element > nelements)
> +               if (element == PG_INT32_MIN || -element > nelements)
>
> This seems like a good opportunity to use our new pg_abs_s32() function,
> and godbolt.org [0] seems to indicate that it might produce better code,
> too (at least to my eye).

This updated version LGTM, I agree it's a good use of pg_abs_s32().

Thanks,
Joseph Koshakow

Reply via email to