On Wed, Aug 14, 2024 at 10:38:49PM +0800, SAMEER KUMAR wrote: > Yes, while reviewing the history of changes, I too noticed the same. The > documentation of older versions (v12 [1]) still has old descriptions.
After reading the related threads and code, I'm inclined to agree that this is a mistake, or at least that the current wording is likely to mislead folks into thinking it has something to do with parallel query. I noticed that your patch changed a few things in the description, but IMHO we should keep the fix focused, i.e., just replace "end of a parallel operation" with "transaction end." I've attached a modified version of the patch with this change. -- nathan
>From e23d495cae2d48e5d52810afff083e2e94df786b Mon Sep 17 00:00:00 2001 From: Nathan Bossart <nat...@postgresql.org> Date: Wed, 14 Aug 2024 14:44:01 -0500 Subject: [PATCH v2 1/1] Fix a couple of wait event descriptions. Author: Sameer Kumar Discussion: https://postgr.es/m/CAGPeHmh6UMrKQHKCmX%2B5vV5TH9P%3DKw9en3k68qEem6J%3DyrZPUA%40mail.gmail.com Backpatch-through: 13 --- src/backend/utils/activity/wait_event_names.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/utils/activity/wait_event_names.txt b/src/backend/utils/activity/wait_event_names.txt index d10ca723dc..8efb4044d6 100644 --- a/src/backend/utils/activity/wait_event_names.txt +++ b/src/backend/utils/activity/wait_event_names.txt @@ -143,7 +143,7 @@ MULTIXACT_CREATION "Waiting for a multixact creation to complete." PARALLEL_BITMAP_SCAN "Waiting for parallel bitmap scan to become initialized." PARALLEL_CREATE_INDEX_SCAN "Waiting for parallel <command>CREATE INDEX</command> workers to finish heap scan." PARALLEL_FINISH "Waiting for parallel workers to finish computing." -PROCARRAY_GROUP_UPDATE "Waiting for the group leader to clear the transaction ID at end of a parallel operation." +PROCARRAY_GROUP_UPDATE "Waiting for the group leader to clear the transaction ID at transaction end." PROC_SIGNAL_BARRIER "Waiting for a barrier event to be processed by all backends." PROMOTE "Waiting for standby promotion." RECOVERY_CONFLICT_SNAPSHOT "Waiting for recovery conflict resolution for a vacuum cleanup." @@ -158,7 +158,7 @@ SYNC_REP "Waiting for confirmation from a remote server during synchronous repli WAL_RECEIVER_EXIT "Waiting for the WAL receiver to exit." WAL_RECEIVER_WAIT_START "Waiting for startup process to send initial data for streaming replication." WAL_SUMMARY_READY "Waiting for a new WAL summary to be generated." -XACT_GROUP_UPDATE "Waiting for the group leader to update transaction status at end of a parallel operation." +XACT_GROUP_UPDATE "Waiting for the group leader to update transaction status at transaction end." ABI_compatibility: -- 2.39.3 (Apple Git-146)
