Dear Hou,
Let me contribute the great feature. I read only the 0001 patch and here are
initial comments.
01. logical-replication.sgml
track_commit_timestamp must be specified only on the subscriber, but it is not
clarified.
Can you write down that?
02. logical-replication.sgml
I felt that the ordering of {exists, differ,missing} should be fixed, but not
done.
For update "differ" is listerd after the "missing", but for delete, "differ"
locates before the "missing". The inconsistency exists on souce code as well.
03. conflict.h
The copyright seems wrong. 2012 is not needed.
04. general
According to the documentation [1], there is another constraint "exclude", which
can cause another type of conflict. But this pattern cannot be logged in detail.
I tested below workload as an example.
=====
publisher=# create table tab (a int, EXCLUDE (a WITH =));
publisher=# create publication pub for all tables;
subscriber=# create table tab (a int, EXCLUDE (a WITH =));
subscriber=# create subscription sub...;
subscriber=# insert into tab values (1);
publisher=# insert into tab values (1);
-> Got conflict with below log lines:
```
ERROR: conflicting key value violates exclusion constraint "tab_a_excl"
DETAIL: Key (a)=(1) conflicts with existing key (a)=(1).
CONTEXT: processing remote data for replication origin "pg_16389" during
message type "INSERT"
for replication target relation "public.tab" in transaction 740, finished at
0/1543940
```
=====
Can we support the type of conflict?
[1]:
https://www.postgresql.org/docs/devel/sql-createtable.html#SQL-CREATETABLE-EXCLUDE
Best regards,
Hayato Kuroda
FUJITSU LIMITED
