On Wednesday, July 31, 2024 5:07 PM Kuroda, Hayato/黒田 隼人 <kuroda.hay...@fujitsu.com> wrote: > > Dear Hou, > > > When reviewing the code in logical/worker.c, I noticed that when > > applying a cross-partition update action, it scans the old partition twice. > > I am attaching the patch 0001 to remove this duplicate table scan. > > Just to clarify, you meant that FindReplTupleInLocalRel() are called in > apply_handle_tuple_routing() and > apply_handle_tuple_routing()->apply_handle_delete_internal(), > which requires the index or sequential scan, right? LGTM.
Thanks for reviewing the patch, and your understanding is correct. Here is the updated patch 0001. I removed the comments as suggested by Amit. Since 0002 patch is only refactoring the code and I need some time to review the comments for it, I will hold it until the 0001 is committed. Best Regards, Hou zj
v2-0001-avoid-duplicate-table-scan-for-cross-partition-up.patch
Description: v2-0001-avoid-duplicate-table-scan-for-cross-partition-up.patch
