Hi, On Tue, Jul 30, 2024 at 01:24:54PM -0500, Nathan Bossart wrote: > While looking into converting pgssEntry->mutex to an LWLock (per a > suggestion elsewhere [0]), I noticed that pg_stat_statements uses > "volatile" quite liberally. IIUC we can remove these as of commit 0709b7e > (like commits 8f6bb85, df4077c, and 6ba4ecb did in other areas). All of > the uses in pg_stat_statements except those added by commit 9fbc3f3 predate > that commit (0709b7e), and I assume commit 9fbc3f3 was just following the > examples in surrounding code. > > Am I missing something? Or can we remove these qualifiers now?
I share the same understanding and I think those can be removed. The patch LGTM. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
