On 7/19/24 04:23, Michael Paquier wrote: > On Fri, Jul 19, 2024 at 12:17:44AM +0200, Tomas Vondra wrote: >> shall we do something about this patch? It seems to be in a pretty good >> shape (pretty much RFC, based on quick review), the cfbot is still >> happy, and there seems to be agreement this is a nice feature. >> >> Michael, I see you've reviewed the patch in January. Do you agree / plan >> to get it committed, or should I take a look? > > This feel off my radar a bit, thanks for the reminder :) > > I have a local branch dating back from January where this patch is > sitting, with something like 50% of the code reviewed. I'd still need > to look at the test coverage, but I did like the proposed patch a lot > based on my notes. > > I may be able to come back to that if not next week, then the week > after that. If you want to handle it yourself before that, that's > fine by me.
OK, if you're already half-way through the review, I'll leave it up to you. I don't think we need to rush, and I'd have to learn about all the psql stuff first anyway. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
