Hi, On Mon, Jul 08, 2024 at 11:20:45AM +0530, Amit Kapila wrote: > On Mon, Jul 8, 2024 at 11:08 AM Bertrand Drouvot > <bertranddrouvot...@gmail.com> wrote: > > > > On Mon, Jul 08, 2024 at 08:46:19AM +0530, Amit Kapila wrote: > > > This sounds better but it is better to add just before we determine > > > am_cascading_walsender as is done in the attached. What do you think? > > > > Thanks! LGTM. > > > > I would like to push this to HEAD only as we don't see any bug that > this change can prevent. What do you think? >
Yeah, fully agree. I don't see how the previous check location could produce any bug. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com