On Wed, May 08, 2024 at 10:09:46AM +0200, Peter Eisentraut wrote: > On 03.05.24 19:13, Nathan Bossart wrote: >> This is likely small potatoes compared to some of the other >> pg_upgrade-related improvements I've proposed [0] [1] or plan to propose, >> but this is easy enough, and I already wrote the patch, so here it is. >> AFAICT there's no reason to bother syncing these dump files to disk. If >> someone pulls the plug during pg_upgrade, it's not like you can resume >> pg_upgrade from where it left off. Also, I think we skipped syncing before >> v10, anyway, as the --no-sync flag was only added in commit 96a7128, which >> added the code to sync dump files, too. > > Looks good to me.
Thanks for looking. I noticed that the version check is unnecessary since we always use the new binary's pg_dump[all], so I removed that in v2. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
>From 265a999ed65bf56491f76ae013f705ab64491486 Mon Sep 17 00:00:00 2001 From: Nathan Bossart <nat...@postgresql.org> Date: Fri, 3 May 2024 10:35:21 -0500 Subject: [PATCH v2 1/1] add --no-sync to pg_upgrade's calls to pg_dump[all] --- src/bin/pg_upgrade/dump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bin/pg_upgrade/dump.c b/src/bin/pg_upgrade/dump.c index 29fb45b928..8345f55be8 100644 --- a/src/bin/pg_upgrade/dump.c +++ b/src/bin/pg_upgrade/dump.c @@ -22,7 +22,7 @@ generate_old_dump(void) /* run new pg_dumpall binary for globals */ exec_prog(UTILITY_LOG_FILE, NULL, true, true, "\"%s/pg_dumpall\" %s --globals-only --quote-all-identifiers " - "--binary-upgrade %s -f \"%s/%s\"", + "--binary-upgrade %s --no-sync -f \"%s/%s\"", new_cluster.bindir, cluster_conn_opts(&old_cluster), log_opts.verbose ? "--verbose" : "", log_opts.dumpdir, @@ -53,7 +53,7 @@ generate_old_dump(void) parallel_exec_prog(log_file_name, NULL, "\"%s/pg_dump\" %s --schema-only --quote-all-identifiers " - "--binary-upgrade --format=custom %s --file=\"%s/%s\" %s", + "--binary-upgrade --format=custom %s --no-sync --file=\"%s/%s\" %s", new_cluster.bindir, cluster_conn_opts(&old_cluster), log_opts.verbose ? "--verbose" : "", log_opts.dumpdir, -- 2.25.1
