On Mon, Apr 08, 2024 at 05:42:35PM -0400, Andrew Dunstan wrote: > Arguably the fact that it points nowhere is a good thing. But feel free to > replace it with something else. It doesn't have to be URLs at all. That > happened simply because it was easy to extract from a very large piece of > JSON I had lying around, probably from the last time I wrote a JSON parser > :-)
: "http://www.theatermania.com/broadway/";, As as matter of fact, this one points to something that seems to be real. Most of the blobs had better be trimmed down. Looking at the code paths in this module, it looks like this could be even simpler than what Jacob is shaving, checking for: - Objects start and end, including booleans, ints and strings for the quotations. - Nested objects, including arrays made of simple JSON objects. Some escape patterns are already checked, but most of them are missing: https://coverage.postgresql.org/src/test/modules/test_json_parser/test_json_parser_incremental.c.gcov.html There is no direct check on test_json_parser_perf.c, either, only a custom rule in the Makefile without specifying something for meson. So it looks like you could do short execution check in a TAP test, at least. -- Michael
signature.asc
Description: PGP signature
