On Wed, Mar 27, 2024 at 3:42 PM Bertrand Drouvot <bertranddrouvot...@gmail.com> wrote: > > 1 === > > My proposal (in text) but feel free to reword it: > > Note that the slots on the standbys that are being synced from a > primary server (whose synced field is true), will get the inactive_since value > from the corresponding remote slot on the primary. Also, after the standby > starts > up, the inactive_since (for such synced slots) will remain zero until the next > synchronization.
WFM. > 2 === > > +=item $node->create_logical_slot_on_standby(self, primary, slot_name, dbname) > > get_slot_inactive_since_value instead? Ugh. Changed. > 3 === > > +against given reference time. > > s/given reference/optional given reference/? Done. > Apart from the above, LGTM. Thanks for reviewing. On Wed, Mar 27, 2024 at 3:43 PM shveta malik <shveta.ma...@gmail.com> wrote: > > Thanks for the patch. Regarding doc, I have few comments. Thanks for reviewing. > a) "inactive_since will remain zero" > Since it is user exposed info and the user finds it NULL in > pg_replication_slots, shall we mention NULL instead of 0? Right. Changed. > b) Since we are referring to the sync cycle here, I feel it will be > good to give a link to that page. > + zero until the next slot sync cycle (see > + <xref linkend="logicaldecoding-replication-slots-synchronization"/> > for > + slot synchronization details). WFM. Please see the attached v28 patch. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
v28-0001-Maintain-inactive_since-for-synced-slots-correct.patch
Description: Binary data
