On Thu, Jan 11, 2024 at 10:01:16AM -0500, Tom Lane wrote: > Alvaro Herrera <alvhe...@alvh.no-ip.org> writes: >> "The logical replication launcher is disabled during binary upgrades, to >> avoid logical replication workers running on the source cluster. That >> would cause replication origins to move forward after having been copied >> to the target cluster, potentially creating conflicts with the copied >> data files." > > "avoid logical replication workers running" still seems like shaky > grammar. Perhaps s/avoid/avoid having/, or write "to prevent logical > replication workers from running ...".
After sleeping on it, your last suggestion sounds better to me, so I've incorporated that with Alvaro's wording (also cleaner than what I have posted), and applied the patch on HEAD. > Also perhaps s/would/could/. Yep. -- Michael
signature.asc
Description: PGP signature