On Wed, Jan 03, 2024 at 10:57:07PM +0100, Jelte Fennema-Nio wrote: > Overall your light edits look good to me. The commit message is very > descriptive and I like the shortening of the comments. The only thing > I feel is that I think lost some my original intent is this sentence: > > + * different types. The outer loop only does a single iteration, so we > expect > + * optimizing compilers will unroll it, thereby optimizing it away. > > The "we expect" reads to me as if we're not very sure that compilers > do this optimization. Even though we are quite sure. Maybe some small > changes like this to clarify that. > > The outer loop only does a single iteration, so we expect that **any** > optimizing compilers will unroll it, thereby optimizing it away. **We > know for sure that gcc and clang do this optimization.**
WFM. Thanks for reviewing the edits. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
