On 21.12.23 07:24, Peter Smith wrote:
#1. GUC name quoting.
Some basic guidelines were decided and a patch is already pushed [1].
<para>
In messages containing configuration variable names, do not include quotes
when the names are visibly not natural English words, such as when they
have underscores, are all-uppercase or have mixed case. Otherwise, quotes
must be added. Do include quotes in a message where an arbitrary variable
name is to be expanded.
</para>
AFAIK there is nothing controversial there, although maybe the
guideline for 'mixed case' needs revisiting depending on objections
about point #2.
Now that I read this again, I think this is wrong.
We should decide the quoting for a category, not the actual content.
Like, quote all file names; do not quote keywords.
This led to the attempted patch to decide the quoting of GUC parameter
names dynamically based on the actual content, which no one really
liked. But then, to preserve consistency, we also need to be uniform in
quoting GUC parameter names where the name is hardcoded.
