On Thu, Nov 30, 2023 at 07:15:54PM -0800, Lev Kokotov wrote: >> I see prepareCommand() is called one more time in >> prepareCommandsInPipeline(). Should you also check the return value >> there? > > Yes, good catch. New patch attached.
Agreed that this is not really helpful as it stands >> It may also be useful to throw this patch on the January commitfest if >> no one else comes along to review/commit it. > > First time contributing, not familiar with the process here, but happy to > learn. The patch you have sent does not apply cleanly on the master branch, could you rebase please? FWIW, I am a bit confused by the state of sendCommand(). Wouldn't it better to consume the errors from PQsendQueryPrepared() and PQsendQueryParams() when these fail? -- Michael
signature.asc
Description: PGP signature
