> I see prepareCommand() is called one more time in > prepareCommandsInPipeline(). Should you also check the return value > there?
Yes, good catch. New patch attached. > It may also be useful to throw this patch on the January commitfest if > no one else comes along to review/commit it. First time contributing, not familiar with the process here, but happy to learn. Best, Lev postgresml.org On Thu, Nov 30, 2023 at 2:10 PM Tristan Partin <tris...@neon.tech> wrote: > On Wed Nov 29, 2023 at 7:38 PM CST, Lev Kokotov wrote: > > Patch attached, if there is any interest in fixing this small bug. > > I see prepareCommand() is called one more time in > prepareCommandsInPipeline(). Should you also check the return value > there? > > It may also be useful to throw this patch on the January commitfest if > no one else comes along to review/commit it. This first set of changes > looks good to me. > > -- > Tristan Partin > Neon (https://neon.tech) >
pgbench.patch
Description: Binary data