On Tue, Oct 31, 2023 at 2:25 AM David Rowley <dgrowle...@gmail.com> wrote: > > On Mon, 30 Oct 2023 at 23:48, Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > On Fri, Oct 27, 2023 at 3:23 AM David Rowley <dgrowle...@gmail.com> wrote: > > > * parallel.c in HandleParallelMessages(): > > > * applyparallelworker.c in HandleParallelApplyMessages(): > > > > Both the above calls are used to handle ERROR/NOTICE messages from > > parallel workers as you have also noticed. The comment atop > > initReadOnlyStringInfo() clearly states that it is used in the > > performance-critical path. So, is it worth changing these places? In > > the future, this may pose the risk of this API being used > > inconsistently. > > I'm ok to leave those ones out. >
The other two look good to me. -- With Regards, Amit Kapila.
