On Tue, Sep 5, 2023 at 12:58 AM Thomas Munro <thomas.mu...@gmail.com> wrote: > I hope we get "snapshot too old" back one day.
Thanks for working on this. Though I wonder why you didn't do something closer to a straight revert of the feature. Why is nbtree still passing around snapshots needlessly? Also, why are there still many comments referencing the feature? There's the one above should_attempt_truncation(), for example. Another appears above init_toast_snapshot(). Are these just oversights, or was it deliberate? You said something about retaining vestiges. -- Peter Geoghegan