On Mon, Jun 12, 2023 at 11:57:45PM -0700, Gurjeet Singh wrote: > On Mon, Jun 12, 2023 at 10:59 PM Nathan Bossart > <nathandboss...@gmail.com> wrote: > > On Sat, May 27, 2023 at 03:17:21PM -0700, Gurjeet Singh wrote: > > > If listen_addresses is empty, then server won't try to open any TCP/IP > > > ports. The patch does not change any language related to that. > > > > Your proposed change notes that the server only starts if it can listen on > > at least one TCP/IP address, which I worry might lead folks to think that > > the server won't start if listen_addresses is empty. > > Perhaps we can prefix that statement with "If listen_addresses is not > empty", like so:
I came up with a slightly modified doc patch, attached. -- Bruce Momjian <br...@momjian.us> https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index f0a50a5f9a..872dcdf325 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -659,7 +659,13 @@ include_dir 'conf.d' to it. The default value is <systemitem class="systemname">localhost</systemitem>, which allows only local TCP/IP <quote>loopback</quote> connections to be - made. While client authentication (<xref + made. If <varname>listen_addresses</varname> is not empty, + the server will start if it can open a <varname>port</varname> + on at least one TCP/IP address. A warning will be emitted for + any TCP/IP address which cannot be opened. + </para> + <para> + While client authentication (<xref linkend="client-authentication"/>) allows fine-grained control over who can access the server, <varname>listen_addresses</varname> controls which interfaces accept connection attempts, which