On Tue, Aug 22, 2023 at 3:42 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > Once we have last_persisted_confirm_flush_lsn, (1) is just an > > optimization on top of that. With that we take the opportunity to > > persist confirmed_flush_lsn which is much farther than the current > > persisted value and thus improving chances of updating restart_lsn and > > catalog_xmin faster after a WAL sender restart. We need to keep that > > in mind when implementing (2). The problem is if we don't implement > > (1) right now, we might just forget to do that small incremental > > change in future. My preference is 1. Do both (1) and (2) together 2. > > Do (2) first and then (1) as a separate commit. 3. Just implement (2) > > if we don't have time at all for first two options. > > > > I prefer one of (2) or (3). Anyway, it is better to do that > optimization (persist confirm_flush_lsn at a regular interval) as a > separate patch as we need to test and prove its value separately.
Fine with me. -- Best Wishes, Ashutosh Bapat
