Dear Amit,
>
> Few minor comments
> 1. Why the patch updates the slots info at the end of
> create_logical_replication_slots()? Can you please update the comments
> for the same?
I checked and agreed that it was not needed. More detail, please see [1].
> 2.
> @@ -36,6 +36,7 @@ generate_old_dump(void)
> {
> char sql_file_name[MAXPGPATH],
> log_file_name[MAXPGPATH];
> +
> DbInfo *old_db = &old_cluster.dbarr.dbs[dbnum];
>
> Spurious line change.
>
Removed.
Next patch set would be available in upcoming posts.
[1]:
https://www.postgresql.org/message-id/TYAPR01MB5866F384AC62E12E9638BEC1F51BA%40TYAPR01MB5866.jpnprd01.prod.outlook.com
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
