On Wed, Jan 04, 2023 at 07:06:44PM +0100, Hannu Krosing wrote: > 1. so I don't have to create the script and function manually each > time I want to test mainly the database (instead of the > client-database system) > > 2. so that new users of PostgreSQL can easily see how much better OLTP > workloads perform when packaged up as a server-side function
I'm not sure we should add micro-optimized versions of the existing scripts to pgbench. Your point about demonstrating the benefits of server-side functions seems reasonable, but it also feels a bit like artifically improving pgbench numbers. I think I'd rather see some more variety in the built-in scripts so that folks can more easily test a wider range of common workloads. Perhaps this could include a test that is focused on server-side functions. In any case, it looks like there is unaddressed feedback for this patch, so I'm marking it as "waiting on author." -- Nathan Bossart Amazon Web Services: https://aws.amazon.com