On Wed, Aug 2, 2023 at 1:00 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Wed, Aug 2, 2023 at 8:10 AM Peter Smith <smithpb2...@gmail.com> wrote: > > > > > > The am_xxx functions are removed now in the v2-0001 patch. See [1]. > > > > The replacement set of macros (the ones with no arg) are not strictly > > necessary, except I felt it would make the code unnecessarily verbose > > if we insist to pass MyLogicalRepWorker everywhere from the callers in > > worker.c / tablesync.c / applyparallelworker.c. > > > > Agreed but having a dual set of macros is also not clean. Can we > provide only a unique set of inline functions instead? >
We can't use the same names for both with/without-parameter functions because there is no function overloading in C. In patch v3-0001 I've replaced the "dual set of macros", with a single inline function of a different name, and one set of space-saving macros. PSA v3 ------ Kind Regards, Peter Smith. Fujitsu Australia
v3-0001-Add-LogicalRepWorkerType-enum.patch
Description: Binary data
v3-0002-Switch-on-worker-type.patch
Description: Binary data
