> On 18 Jul 2023, at 18:04, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Daniel Gustafsson <dan...@yesql.se> writes: >> Looking at the upgrade question in [0] made me realize that we discard >> potentially useful information for troubleshooting. When we check if the >> cluster is properly shut down we might as well include the status from >> pg_controldata in the errormessage as per the trivial (but yet untested) >> proposed diff. > >> Is there a reason not to be verbose here as users might copy/paste this >> output >> when asking for help? > > Agreed, but I think you need to chomp the string's trailing newline, > or it'll look ugly. You might as well do that further up and remove > the newlines from the comparison strings, too.
Yeah, the previous diff was mostly a sketch. The attached strips newline and makes the comparisons a bit neater in the process due to that. Will apply this trivial but seemingly useful change unless objected to. -- Daniel Gustafsson
v2-0001-pg_upgrade-include-additional-detail-in-cluster-c.patch
Description: Binary data
