Looking at the upgrade question in [0] made me realize that we discard potentially useful information for troubleshooting. When we check if the cluster is properly shut down we might as well include the status from pg_controldata in the errormessage as per the trivial (but yet untested) proposed diff.
Is there a reason not to be verbose here as users might copy/paste this output when asking for help? -- Daniel Gustafsson [0] CACoPQdbQTysF=ekckyfngtdpodxxmesf_2acno+bcnqqcb5...@mail.gmail.com
pg_upgrade_controldata.diff
Description: Binary data