David Steele <da...@pgmasters.net> writes:
> On 6/10/23 09:57, Amit Langote wrote:
>> I too have been thinking that setting relkind might be a good idea, even
>> if only as a crosscheck that only view relations can look like that in
>> the range table.
> +1. Even better if we can do it for PG16.
Well, if we're gonna do it we should do it for v16, rather than
change the data structure twice. It wouldn't be hard exactly:
/*
* Clear fields that should not be set in a subquery RTE. Note that we
* leave the relid, rellockmode, and perminfoindex fields set, so that the
* view relation can be appropriately locked before execution and its
* permissions checked.
*/
- rte->relkind = 0;
rte->tablesample = NULL;
rte->inh = false; /* must not be set for a subquery */
plus adjustment of that comment and probably also the comment
for struct RangeTblEntry.
regards, tom lane
